Skip to content

[Uptime] Make duration line series use local for time zone value#123470

Merged
justinkambic merged 1 commit intoelastic:mainfrom
justinkambic:123466/fix-duration-chart-time-zone-error
Jan 20, 2022
Merged

[Uptime] Make duration line series use local for time zone value#123470
justinkambic merged 1 commit intoelastic:mainfrom
justinkambic:123466/fix-duration-chart-time-zone-error

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic commented Jan 20, 2022

Summary

Resolves #123466.

As part of a recent version upgrade for Elastic Charts, we missed that the time zone value for the duration series on the Uptime detail page no longer displays values in accordance with the rest of the plugin.

This patch will fix the disparity.

Testing this PR

The results of this patch are easily observable. See the linked issue for detailed repro steps.

Before

image

After

image

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0 v7.17.0 labels Jan 20, 2022
@justinkambic justinkambic requested a review from a team as a code owner January 20, 2022 15:20
@justinkambic justinkambic self-assigned this Jan 20, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 20, 2022

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic requested a review from markov00 January 20, 2022 15:20
markov00
markov00 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 20, 2022
@justinkambic justinkambic enabled auto-merge (squash) January 20, 2022 15:55
@justinkambic justinkambic added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 20, 2022
dominiqueclarke
dominiqueclarke approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jan 20, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 688.4KB 688.4KB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit 067da14 into elastic:main Jan 20, 2022
@kibanamachine kibanamachine mentioned this pull request Jan 20, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 20, 2022
@justinkambic @kibanamachine
Make duration line series use local for time zone value. (elastic#1…
ec1013f 
…23470)

(cherry picked from commit 067da14)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 20, 2022
@justinkambic @kibanamachine
Make duration line series use local for time zone value. (elastic#1…
3fdd23f 
…23470)

(cherry picked from commit 067da14)
@kibanamachine kibanamachine mentioned this pull request Jan 20, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 20, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@dominiqueclarke dominiqueclarke deleted the 123466/fix-duration-chart-time-zone-error branch January 20, 2022 16:57
kibanamachine added a commit that referenced this pull request Jan 20, 2022
@kibanamachine @justinkambic
Make duration line series use local for time zone value. (#123470) (#…
f8ce78b 
…123485)

(cherry picked from commit 067da14)

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
kibanamachine added a commit that referenced this pull request Jan 20, 2022
@kibanamachine @justinkambic
Make duration line series use local for time zone value. (#123470) (#…
867724d 
…123484)

(cherry picked from commit 067da14)

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
@justinkambic justinkambic mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@justinkambic justinkambic

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.17.0 v8.0.0 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Duration chart time zone is no longer working

6 participants

@justinkambic @elasticmachine @kibana-ci @kibanamachine @markov00 @dominiqueclarke